Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(launch): fix the type of the override args passed through to a LaunchProject from a Job #4416

Merged
merged 9 commits into from Nov 7, 2022

Conversation

KyleGoyette
Copy link
Contributor

@KyleGoyette KyleGoyette commented Oct 27, 2022

Fixes WB-11355
Fixes #NNNN

Description

Fixes the type of the override args passed through to a LaunchProject from a Job

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" and/or GitHub issue "Fixes #NNNN" (if applicable)
  • Ensure PR title compliance with the conventional commits standards

@github-actions github-actions bot added cc-fix and removed cc-fix labels Oct 27, 2022
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #4416 (bbe7263) into main (a6d6e2d) will increase coverage by 0.06%.
The diff coverage is 33.33%.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##             main    #4416      +/-   ##
==========================================
+ Coverage   83.01%   83.07%   +0.06%     
==========================================
  Files         258      258              
  Lines       32865    32865              
==========================================
+ Hits        27282    27302      +20     
+ Misses       5583     5563      -20     
Flag Coverage Δ
functest 56.88% <33.33%> (+0.03%) ⬆️
unittest 73.16% <0.00%> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/apis/public.py 82.04% <33.33%> (ø)
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/sdk/wandb_run.py 91.03% <0.00%> (+0.29%) ⬆️
wandb/sdk/wandb_setup.py 88.94% <0.00%> (+0.50%) ⬆️
wandb/sdk/internal/internal_api.py 89.43% <0.00%> (+0.51%) ⬆️
wandb/sdk/lib/printer.py 89.24% <0.00%> (+0.63%) ⬆️
wandb/sdk/lib/sock_client.py 94.17% <0.00%> (+1.05%) ⬆️
wandb/integration/tensorboard/monkeypatch.py 92.59% <0.00%> (+2.46%) ⬆️
wandb/sdk/internal/system/system_info.py 91.55% <0.00%> (+3.24%) ⬆️

@KyleGoyette KyleGoyette marked this pull request as ready for review October 27, 2022 17:56
@github-actions github-actions bot added cc-fix and removed cc-fix labels Oct 27, 2022
@KyleGoyette KyleGoyette added this to the sdk-2022-11.1 milestone Oct 27, 2022
@raubitsj raubitsj modified the milestones: sdk-2022-11.1, sdk-2022-12.1 Nov 3, 2022
Copy link
Contributor

@gtarpenning gtarpenning left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, might consider DRYing this out in the future...

@KyleGoyette KyleGoyette merged commit 63941ea into main Nov 7, 2022
@KyleGoyette KyleGoyette deleted the launch/fix-broken-job-args branch November 7, 2022 20:37
@KyleGoyette KyleGoyette modified the milestones: sdk-2022-12.1, sdk-2022-11.2 Nov 10, 2022
andrewtruong pushed a commit that referenced this pull request Dec 2, 2022
…#4416)

* wip

* update test

* update

* wip

* fix test

Co-authored-by: Dmitry Duev <dmitryduev@users.noreply.github.com>
@kptkin kptkin changed the title fix(launch): Fix LaunchProject override_arg format when setb from Job fix(launch): fix LaunchProject override_arg format when set from Job Dec 6, 2022
@github-actions github-actions bot added cc-fix and removed cc-fix labels Dec 6, 2022
@kptkin kptkin changed the title fix(launch): fix LaunchProject override_arg format when set from Job fix(launch): fix the type of the override args passed through to a LaunchProject from a Job Dec 6, 2022
@github-actions github-actions bot added cc-fix and removed cc-fix labels Dec 6, 2022
@kptkin kptkin modified the milestones: sdk-2022-11.2, sdk-2022-12.2, sdk-2022-12.1 Sep 22, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants