Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove Slack orb usage from Win job on CircleCI #4171

Merged
merged 2 commits into from
Aug 25, 2022
Merged

Remove Slack orb usage from Win job on CircleCI #4171

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
ba99a44
Use bash.exe in win job with slack orb on CircleCI
dmitryduev Aug 24, 2022
868fbc0
Slack orb does not support Windows
dmitryduev Aug 24, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
17 changes: 1 addition & 16 deletions .circleci/config.yml
View file
Open in desktop
Expand Up @@ -344,9 +344,6 @@ jobs:
execute:
type: boolean
default: true
notify_on_failure:
type: boolean
default: false
executor:
name: win/<< parameters.machine_executor >>
size: << parameters.executor_size >>
Expand Down Expand Up @@ -388,16 +385,6 @@ jobs:
DATE=$(date -u +%Y%m%d) CI_PYTEST_PARALLEL=<< parameters.xdist >> CI_PYTEST_SPLIT_ARGS="--splits $CIRCLE_NODE_TOTAL --group $(( $CIRCLE_NODE_INDEX + 1 ))" tox -v -e << parameters.toxenv >>
no_output_timeout: 10m
- save-test-results
# conditionally post a notification to slack if the job failed
- when:
condition: << parameters.notify_on_failure >>
steps:
- slack/notify:
event: fail
template: basic_fail_1
mentions: "@channel"
# taken from slack-secrets context
channel: $SLACK_SDK_NIGHTLY_CI_CHANNEL

mac:
parameters:
Expand Down Expand Up @@ -1012,7 +999,6 @@ workflows:
toxenv: "standalone-gpu-py<<matrix.python_version_major>><<matrix.python_version_minor>>"
parallelism: 2
xdist: 1
notify_on_failure: true
#
# standalone tests on gke
#
Expand Down Expand Up @@ -1305,9 +1291,8 @@ workflows:
toxenv: "standalone-gpu-py<<matrix.python_version_major>><<matrix.python_version_minor>>"
parallelism: 2
xdist: 1
notify_on_failure: true
#
# stanalone tests on gke
# standalone tests on gke
#
- slack_notify:
name: "slack-notify-on-start"
Expand Down