Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Slack orb usage from Win job on CircleCI #4171

Merged
merged 2 commits into from Aug 25, 2022
Merged

Conversation

dmitryduev
Copy link
Member

@dmitryduev dmitryduev commented Aug 24, 2022

Description

...because Windows is currently not supported by the Slack orb, see CircleCI-Public/slack-orb#282.

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

@dmitryduev dmitryduev changed the title Use bash.exe in Win job with the Slack orb on CircleCI Remove Slack orb usage from Win job on CircleCI Aug 24, 2022
@dmitryduev dmitryduev requested a review from a team August 24, 2022 21:15
@codecov
Copy link

codecov bot commented Aug 24, 2022

Codecov Report

Merging #4171 (868fbc0) into master (4c87b36) will increase coverage by 0.05%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4171      +/-   ##
==========================================
+ Coverage   82.66%   82.72%   +0.05%     
==========================================
  Files         256      256              
  Lines       32533    32533              
==========================================
+ Hits        26894    26912      +18     
+ Misses       5639     5621      -18     
Flag Coverage Δ
functest 55.01% <ø> (+0.03%) ⬆️
unittest 73.50% <ø> (+0.07%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/wandb_login.py 94.54% <0.00%> (-0.61%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/sdk/wandb_setup.py 88.94% <0.00%> (+0.50%) ⬆️
wandb/sdk/internal/internal_api.py 86.98% <0.00%> (+0.90%) ⬆️
wandb/filesync/step_prepare.py 94.93% <0.00%> (+1.26%) ⬆️
wandb/integration/tensorboard/monkeypatch.py 92.59% <0.00%> (+2.46%) ⬆️
wandb/sdk/internal/meta.py 90.79% <0.00%> (+3.06%) ⬆️
wandb/sdk/internal/artifacts.py 87.50% <0.00%> (+3.12%) ⬆️

@dmitryduev dmitryduev merged commit 70388b3 into master Aug 25, 2022
@dmitryduev dmitryduev deleted the nightly-win-slack branch August 25, 2022 04:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants