New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add isort support with black profile #4136
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #4136 +/- ##
==========================================
- Coverage 82.72% 82.71% -0.01%
==========================================
Files 256 256
Lines 32576 32534 -42
==========================================
- Hits 26950 26912 -38
+ Misses 5626 5622 -4
Flags with carried forward coverage won't be shown. Click here to find out more.
|
raubitsj
approved these changes
Aug 19, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
GREAT!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What does the PR do?
This PR introduced the
isort
lint tool that sorts all the imports according to the black style.This PR remove the
flake8-import-order
plugging since it doesn't supportblack
style andisort
already provides both checks and ability to re-format the code.This PR also re-formatted all the files in the repo except from the following:
wandb/vendor
wandb/proto
wandb/__init__.py
<- formatting this caused some breakage, so i'm leaving it for future workTesting
How was this PR tested?
This PR is just reformat, ideal if everything done correctly all the test should pass