Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add isort support with black profile #4136

Merged
merged 22 commits into from Aug 19, 2022
Merged

add isort support with black profile #4136

merged 22 commits into from Aug 19, 2022

Conversation

kptkin
Copy link
Contributor

@kptkin kptkin commented Aug 18, 2022

Description

What does the PR do?

This PR introduced the isort lint tool that sorts all the imports according to the black style.
This PR remove the flake8-import-order plugging since it doesn't support black style and isort already provides both checks and ability to re-format the code.

This PR also re-formatted all the files in the repo except from the following:

  • wandb/vendor
  • wandb/proto
  • wandb/__init__.py <- formatting this caused some breakage, so i'm leaving it for future work

Testing

How was this PR tested?

This PR is just reformat, ideal if everything done correctly all the test should pass

@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #4136 (9eb9a93) into master (117c48d) will decrease coverage by 0.01%.
The diff coverage is 92.21%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4136      +/-   ##
==========================================
- Coverage   82.72%   82.71%   -0.01%     
==========================================
  Files         256      256              
  Lines       32576    32534      -42     
==========================================
- Hits        26950    26912      -38     
+ Misses       5626     5622       -4     
Flag Coverage Δ
functest 55.01% <75.14%> (-0.05%) ⬇️
unittest 73.47% <76.34%> (-0.03%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/apis/reports/blocks.py 100.00% <ø> (ø)
wandb/data_types.py 82.65% <ø> (ø)
wandb/filesync/dir_watcher.py 87.76% <ø> (ø)
wandb/filesync/step_prepare.py 94.93% <ø> (ø)
wandb/filesync/step_upload.py 95.04% <ø> (ø)
wandb/integration/catboost/catboost.py 90.56% <ø> (ø)
wandb/integration/kfp/kfp_patch.py 83.33% <ø> (ø)
wandb/integration/sacred/__init__.py 55.31% <ø> (ø)
wandb/integration/sb3/sb3.py 82.14% <ø> (ø)
wandb/integration/tensorboard/monkeypatch.py 90.12% <ø> (-2.47%) ⬇️
... and 163 more

@kptkin kptkin marked this pull request as ready for review August 18, 2022 23:56
@kptkin kptkin requested a review from a team as a code owner August 18, 2022 23:56
Copy link
Member

@raubitsj raubitsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

GREAT!

@kptkin kptkin enabled auto-merge (squash) August 19, 2022 04:45
@kptkin kptkin disabled auto-merge August 19, 2022 05:24
@kptkin kptkin merged commit 9c77726 into master Aug 19, 2022
@kptkin kptkin deleted the add-isort branch August 19, 2022 05:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants