Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

configure tox with dynamic resolution #4138

Merged
merged 5 commits into from Aug 19, 2022
Merged

configure tox with dynamic resolution #4138

merged 5 commits into from Aug 19, 2022

Conversation

kptkin
Copy link
Contributor

@kptkin kptkin commented Aug 19, 2022

Description

What does the PR do?

Follow up to tie some loose ends from this PR: #4136
This PR, cleans up the configuration file and makes the tox command more generic - do we want to format the entire folder?

This PR also re-enables the pre-commit hooks

Testing

How was this PR tested?

This is just formatting, hence expecting test to pass as a sign that all worked correctly!

@kptkin kptkin marked this pull request as ready for review August 19, 2022 07:22
@codecov
Copy link

codecov bot commented Aug 19, 2022

Codecov Report

Merging #4138 (3d67ff5) into master (486cc58) will increase coverage by 0.01%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4138      +/-   ##
==========================================
+ Coverage   82.70%   82.71%   +0.01%     
==========================================
  Files         256      256              
  Lines       32534    32534              
==========================================
+ Hits        26906    26912       +6     
+ Misses       5628     5622       -6     
Flag Coverage Δ
functest 54.99% <ø> (ø)
unittest 73.47% <ø> (+0.01%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/agents/pyagent.py 70.80% <0.00%> (-1.61%) ⬇️
wandb/sdk/lib/sock_client.py 92.59% <0.00%> (-1.06%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/sdk/wandb_run.py 91.16% <0.00%> (+0.24%) ⬆️
wandb/filesync/step_prepare.py 94.93% <0.00%> (+1.26%) ⬆️
wandb/integration/tensorboard/monkeypatch.py 90.12% <0.00%> (+2.46%) ⬆️
wandb/sdk/internal/meta.py 90.79% <0.00%> (+3.06%) ⬆️

@dmitryduev dmitryduev self-requested a review August 19, 2022 08:44
Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

While you're at it...mind fixing the pre-commit hook as well?

Copy link
Member

@dmitryduev dmitryduev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

♨️

@kptkin kptkin merged commit e56945e into master Aug 19, 2022
@kptkin kptkin deleted the isort-fixes branch August 19, 2022 17:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants