Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require sdk-team to approve API changes #4128

Merged
merged 4 commits into from Aug 18, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 2 additions & 0 deletions .github/CODEOWNERS
Validating CODEOWNERS rules …
@@ -1,2 +1,4 @@
# GraphQL changes need extra scrutiny
/wandb/sdk/internal/internal_api.py @wandb/sdk-team
# Changing interfaces need extra scrutiny
/tests/unit_tests/test_library_public.py @wandb/sdk-team
36 changes: 36 additions & 0 deletions tests/unit_tests/test_library_public.py
Expand Up @@ -8,6 +8,8 @@
- deprecate ones that were public but we want to remove

"""
import inspect

import wandb

SYMBOLS_ROOT_DATATYPES = {
Expand Down Expand Up @@ -259,3 +261,37 @@ def test_library_config():
symbol_public_set - SYMBOLS_CONFIG - SYMBOLS_CONFIG_OTHER - SYMBOLS_TYPING
)
assert symbol_unknown == set()


SYMBOLS_WANDB_INIT = {
"force",
"settings",
"project",
"tensorboard",
"config",
"allow_val_change",
"id",
"monitor_gym",
"magic",
"group",
"resume",
"dir",
"anonymous",
"mode",
"config_exclude_keys",
"tags",
"name",
"entity",
"sync_tensorboard",
"config_include_keys",
"save_code",
"notes",
"job_type",
"reinit",
}


def test_library_init():
init_params = set(inspect.signature(wandb.init).parameters)
print("init_params", init_params)
assert init_params == SYMBOLS_WANDB_INIT