Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require sdk-team to approve API changes #4128

Merged
merged 4 commits into from Aug 18, 2022
Merged

Conversation

raubitsj
Copy link
Member

Description

Lock more stuff down!

Testing

Not tested

@raubitsj raubitsj requested a review from a team August 17, 2022 22:10
@codecov
Copy link

codecov bot commented Aug 17, 2022

Codecov Report

Merging #4128 (6db0583) into master (825add5) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4128      +/-   ##
==========================================
+ Coverage   82.69%   82.73%   +0.03%     
==========================================
  Files         256      256              
  Lines       32519    32519              
==========================================
+ Hits        26893    26904      +11     
+ Misses       5626     5615      -11     
Flag Coverage Δ
functest 55.01% <ø> (+0.21%) ⬆️
unittest 73.49% <ø> (+0.05%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/launch/agent/agent.py 91.54% <0.00%> (-0.71%) ⬇️
wandb/sdk/lib/git.py 79.01% <0.00%> (ø)
wandb/cli/cli.py 68.99% <0.00%> (+0.09%) ⬆️
wandb/sdk/interface/artifacts.py 79.23% <0.00%> (+0.34%) ⬆️
wandb/sdk/wandb_setup.py 89.00% <0.00%> (+0.50%) ⬆️
wandb/sdk/internal/internal_api.py 87.01% <0.00%> (+0.51%) ⬆️
wandb/sdk/internal/meta.py 90.79% <0.00%> (+3.06%) ⬆️

@raubitsj raubitsj merged commit efc85b7 into master Aug 18, 2022
@raubitsj raubitsj deleted the codeowners-public-symbols branch August 18, 2022 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants