Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix for coverage tool and new circle config #4076

Closed
wants to merge 2 commits into from

Conversation

raubitsj
Copy link
Member

@raubitsj raubitsj commented Aug 10, 2022

Fixes WB-NNNN
Fixes #NNNN

Description

What does the PR do?

jobs list:

% ./tools/coverage-tool.py jobs                                                                                                                                                                                         (unmock-server-coverage-tool)wandb
workflows.main.jobs.1.pytest   py36,covercircle
workflows.main.jobs.1.pytest   py37,covercircle
workflows.main.jobs.1.pytest   py38,covercircle
workflows.main.jobs.1.pytest   py39,covercircle
workflows.main.jobs.1.pytest   py310,covercircle
workflows.main.jobs.2.tox-base py36,covercircle
workflows.main.jobs.2.tox-base py37,covercircle
workflows.main.jobs.2.tox-base py38,covercircle
workflows.main.jobs.2.tox-base py39,covercircle
workflows.main.jobs.2.tox-base py310,covercircle
workflows.main.jobs.3.tox-base func-s_base-py37,func-covercircle
workflows.main.jobs.3.tox-base func-s_sklearn-py37,func-covercircle
workflows.main.jobs.3.tox-base func-s_metaflow-py37,func-covercircle
workflows.main.jobs.3.tox-base func-s_tf115-py37,func-covercircle
workflows.main.jobs.3.tox-base func-s_tf21-py37,func-covercircle
workflows.main.jobs.3.tox-base func-s_tf25-py37,func-covercircle
workflows.main.jobs.3.tox-base func-s_tf26-py37,func-covercircle
workflows.main.jobs.3.tox-base func-s_ray112-py37,func-covercircle
workflows.main.jobs.3.tox-base func-s_ray2-py37,func-covercircle
workflows.main.jobs.3.tox-base func-s_service-py37,func-covercircle
workflows.main.jobs.3.tox-base func-s_noml-py37,func-covercircle
workflows.main.jobs.3.tox-base func-s_grpc-py37,func-covercircle
workflows.main.jobs.3.tox-base func-s_docs-py37,func-covercircle
workflows.main.jobs.6.win.0    py37,wincovercircle -- --timeout 300 tests/unit_tests_new
workflows.main.jobs.6.win.1    py37,wincovercircle -- --timeout 300 tests/unit_tests_new
workflows.main.jobs.6.win.2    py37,wincovercircle -- --timeout 300 tests/unit_tests_new
workflows.main.jobs.6.win.3    py37,wincovercircle -- --timeout 300 tests/unit_tests_new
workflows.main.jobs.7.mac.0    py39,covercircle
workflows.main.jobs.7.mac.1    py39,covercircle
workflows.main.jobs.7.mac.2    py39,covercircle
workflows.main.jobs.7.mac.3    py39,covercircle
workflows.main.jobs.8.launch   pylaunch,covercircle
workflows.main.jobs.9.tox-base unit-s_nb-py36,unit-covercircle

Testing

How was this PR tested?

Checklist

  • Include reference to internal ticket "Fixes WB-NNNN" (and github issue "Fixes #NNNN" if applicable)

@codecov
Copy link

codecov bot commented Aug 10, 2022

Codecov Report

Merging #4076 (157c497) into unmock-server (3312ec6) will decrease coverage by 0.00%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                @@
##           unmock-server    #4076      +/-   ##
=================================================
- Coverage          82.75%   82.74%   -0.01%     
=================================================
  Files                255      255              
  Lines              32266    32266              
=================================================
- Hits               26701    26699       -2     
- Misses              5565     5567       +2     
Flag Coverage Δ
functest 54.93% <ø> (-0.02%) ⬇️
unittest 73.50% <ø> (+0.04%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
wandb/sdk/lib/sock_client.py 89.92% <0.00%> (-1.44%) ⬇️
wandb/sdk/service/server_sock.py 91.87% <0.00%> (-1.02%) ⬇️
wandb/sdk/wandb_run.py 91.01% <0.00%> (-0.25%) ⬇️
wandb/integration/tensorboard/monkeypatch.py 90.12% <0.00%> (ø)
wandb/sdk/wandb_setup.py 89.00% <0.00%> (+0.50%) ⬆️
wandb/sdk/internal/internal_api.py 86.90% <0.00%> (+0.51%) ⬆️
wandb/sdk/launch/agent/agent.py 92.95% <0.00%> (+0.70%) ⬆️

@dmitryduev dmitryduev self-requested a review August 10, 2022 07:29
@kptkin
Copy link
Contributor

kptkin commented Aug 10, 2022

merged partially into #4066

@kptkin kptkin closed this Aug 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants