Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactors pytest unit tests to run against real wandb server #4066

Merged
merged 40 commits into from Aug 10, 2022

Conversation

kptkin
Copy link
Contributor

@kptkin kptkin commented Aug 7, 2022

Description

What does the PR do?

https://www.notion.so/wandbai/Un-mock-my-mock-server-0202bd99f1844ba086ab615bec9f4e57

Testing

How was this PR tested?

How do you test a test?! 馃

@codecov
Copy link

codecov bot commented Aug 7, 2022

Codecov Report

Merging #4066 (c108f5d) into master (ef0c522) will increase coverage by 2.61%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #4066      +/-   ##
==========================================
+ Coverage   80.13%   82.74%   +2.61%     
==========================================
  Files         255      255              
  Lines       32269    32266       -3     
==========================================
+ Hits        25859    26700     +841     
+ Misses       6410     5566     -844     
Flag Coverage 螖
functest 54.93% <酶> (+4.58%) 猬嗭笍
unittest 73.50% <酶> (+0.05%) 猬嗭笍

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage 螖
wandb/data_types.py 82.65% <酶> (-1.76%) 猬囷笍
wandb/integration/prodigy/prodigy.py 95.00% <酶> (+95.00%) 猬嗭笍
wandb/sdk/launch/runner/local_process.py 59.52% <0.00%> (-28.58%) 猬囷笍
wandb/integration/tensorboard/monkeypatch.py 87.65% <0.00%> (-4.94%) 猬囷笍
wandb/sdk/data_types/base_types/wb_value.py 93.81% <0.00%> (-2.07%) 猬囷笍
wandb/sdk/wandb_artifacts.py 81.78% <0.00%> (-1.26%) 猬囷笍
wandb/sdk/service/server_sock.py 91.87% <0.00%> (-1.02%) 猬囷笍
wandb/cli/cli.py 70.29% <0.00%> (-0.47%) 猬囷笍
wandb/sdk/interface/artifacts.py 78.89% <0.00%> (-0.35%) 猬囷笍
... and 54 more

@dmitryduev dmitryduev changed the title split tests to old and new unit tests Refactors pytest unit tests to run against real wandb server Aug 9, 2022
@kptkin kptkin marked this pull request as ready for review August 10, 2022 03:57
wandb/sdk/launch/utils.py Outdated Show resolved Hide resolved
@raubitsj raubitsj self-requested a review August 10, 2022 19:49
Copy link
Member

@raubitsj raubitsj left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

馃殺 Great!!!
None of my comments were blocking.

@kptkin kptkin merged commit 6db0993 into master Aug 10, 2022
@kptkin kptkin deleted the unmock-server branch August 10, 2022 23:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants