Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Get rid of "--delay" mocha CLI option #364

Merged
merged 8 commits into from
Sep 22, 2021
Merged

Get rid of "--delay" mocha CLI option #364

merged 8 commits into from
Sep 22, 2021

Commits on Sep 22, 2021

  1. Get rid of "--delay" mocha CLI option 

    This is needed to fix #363. The `--delay` option requires the code to call the
`run` function only once and we were calling it multiple times. More
importantly, Mocha does not catch exceptions thrown at the root level and simply
reports nothing when that happens. These exceptions typically get thrown when
the IDL cannot be parsed, meaning that invalid data exceptions mostly went
unnoticed...

This update wraps all code that needs to run before tests in a `before`
function. Note the need to keep a "dummy" test at the root level, otherwise the
`before` function won't run (and wouldn't have anywhere to report failure).

This update slightly improves describe/it tests naming as well.
    @tidoust
    tidoust committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    f731a2e View commit details
    Browse the repository at this point in the history

  2. Drop consistency tests for CSS 

    Too early for that :)
    @tidoust
    tidoust committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    c063722 View commit details
    Browse the repository at this point in the history

  3. Update test/idl/package.js 

    Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>
    @tidoust @dontcallmedom
    tidoust and dontcallmedom committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    927b130 View commit details
    Browse the repository at this point in the history

  4. Update test/css/all.js 

    Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>
    @tidoust @dontcallmedom
    tidoust and dontcallmedom committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    f04d3b2 View commit details
    Browse the repository at this point in the history

  5. Update test/css/package.js 

    Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>
    @tidoust @dontcallmedom
    tidoust and dontcallmedom committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    0efb354 View commit details
    Browse the repository at this point in the history

  6. Update test/elements/all.js 

    Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>
    @tidoust @dontcallmedom
    tidoust and dontcallmedom committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    aa542ae View commit details
    Browse the repository at this point in the history

  7. Update test/elements/consistency.js 

    Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>
    @tidoust @dontcallmedom
    tidoust and dontcallmedom committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    52f844b View commit details
    Browse the repository at this point in the history

  8. Update test/css/parse.js 

    Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>
    @tidoust @dontcallmedom
    tidoust and dontcallmedom committed Sep 22, 2021
    Configuration menu
    Copy the full SHA
    882bf12 View commit details
    Browse the repository at this point in the history