Get rid of "--delay" mocha CLI option #364
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is needed to fix #363. The `--delay` option requires the code to call the `run` function only once and we were calling it multiple times. More importantly, Mocha does not catch exceptions thrown at the root level and simply reports nothing when that happens. These exceptions typically get thrown when the IDL cannot be parsed, meaning that invalid data exceptions mostly went unnoticed... This update wraps all code that needs to run before tests in a `before` function. Note the need to keep a "dummy" test at the root level, otherwise the `before` function won't run (and wouldn't have anywhere to report failure). This update slightly improves describe/it tests naming as well.
|
Dammit, I inadvertently committed additional unicity tests for CSS that cannot pass today. Will rollback... |
Too early for that :)
|
Tests now fail because they actually run, and detect that |
dontcallmedom
approved these changes
Sep 22, 2021
Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>
Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>
Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>
Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>
Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>
Co-authored-by: Dominique Hazael-Massieux <dom@w3.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is needed to fix #363. The
--delayoption requires the code to call therunfunction only once and we were calling it multiple times. More importantly, Mocha does not catch exceptions thrown at the root level and simply reports nothing when that happens. These exceptions typically get thrown when the IDL cannot be parsed, meaning that invalid data exceptions mostly went unnoticed...This update wraps all code that needs to run before tests in a
beforefunction. Note the need to keep a "dummy" test at the root level, otherwise thebeforefunction won't run (and wouldn't have anywhere to report failure). This workaround is somewhat documented in mocha's repository, see mochajs/mocha#2116 (comment)This update slightly improves describe/it tests naming as well.