New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(package): update deps #3358
Changes from 4 commits
153ad78
3ca9971
1cca9b8
4f8ac5d
369080e
bc35c85
cceaaa1
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -135,18 +135,19 @@ describe("Core — Data Include", () => { | |
body: ` | ||
<section id="abstract"></section> | ||
|
||
<section data-include="${include}" data-include-format="markdown"></section> | ||
<section id="test" data-include="${include}" data-include-format="markdown"></section> | ||
`, | ||
}; | ||
ops.abstract = null; | ||
|
||
const doc = await makeRSDoc(ops); | ||
const li = doc.querySelector("section li"); | ||
const li = doc.querySelector("section#test li"); | ||
expect(li).toBeTruthy(); | ||
expect(li.textContent).toContain("Rose"); | ||
expect(li.textContent).toContain("Blue"); | ||
expect(li.textContent).toContain("Red"); | ||
expect(li.textContent).toContain("wasteland"); | ||
expect(li.textContent).toBe("Rose"); | ||
const [p1, p2, p3] = [...doc.querySelectorAll("#test p")]; | ||
expect(p1.textContent).toContain("Blue"); | ||
expect(p2.textContent).toContain("Red"); | ||
expect(p3.textContent).toContain("wasteland"); | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. See markedjs/marked#1934 (and the fix: markedjs/marked#1936) There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The intention here was to wrap them to There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 3-space fixes it. Shouldn't be a breaking change for us as we've delegated markdown related changes on marked, which is commonmark compliant (almost). |
||
// Shouldn't break other sections | ||
expect(doc.getElementById("abstract")).toBeTruthy(); | ||
}); | ||
|
@@ -160,7 +161,7 @@ describe("Core — Data Include", () => { | |
body: ` | ||
<section id="abstract"></section> | ||
|
||
<section> | ||
<section id="test"> | ||
|
||
<div data-include="${include}" data-include-format="markdown" data-include-replace></div> | ||
|
||
|
@@ -170,12 +171,13 @@ describe("Core — Data Include", () => { | |
ops.abstract = null; | ||
|
||
const doc = await makeRSDoc(ops); | ||
const li = doc.querySelector("section li"); | ||
const li = doc.querySelector("section#test li"); | ||
expect(li).toBeTruthy(); | ||
expect(li.textContent).toContain("Rose"); | ||
expect(li.textContent).toContain("Blue"); | ||
expect(li.textContent).toContain("Red"); | ||
expect(li.textContent).toContain("wasteland"); | ||
expect(li.textContent).toBe("Rose"); | ||
const [p1, p2, p3] = [...doc.querySelectorAll("#test p")]; | ||
expect(p1.textContent).toContain("Blue"); | ||
expect(p2.textContent).toContain("Red"); | ||
expect(p3.textContent).toContain("wasteland"); | ||
expect(li.parentElement.parentElement.localName).toBe("section"); | ||
// Shouldn't break other sections | ||
expect(doc.getElementById("abstract")).toBeTruthy(); | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why do we still have this here?