chore(package): update deps #3358
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sidvishnoi
reviewed
Mar 3, 2021
| "eslint-plugin-import": "^2.22.1", | ||
| "eslint-plugin-jasmine": "^4.1.2", | ||
| "eslint-plugin-prettier": "^3.3.1", | ||
| "hyperhtml": "^2.34.0", | ||
| "idb": "^6.0.0", | ||
| "jasmine": "^3.6.4", | ||
| "jquery": "^3.5.1", | ||
| "jquery": "^3.6.0", |
There was a problem hiding this comment.
why do we still have this here?
sidvishnoi
approved these changes
Mar 3, 2021
sidvishnoi
reviewed
Mar 3, 2021
tests/spec/core/data-include-spec.js
Outdated
Comment on lines
144
to
150
| const li = doc.querySelector("section li"); | ||
| const li = doc.querySelector("section#test li"); | ||
| expect(li).toBeTruthy(); | ||
| expect(li.textContent).toContain("Rose"); | ||
| expect(li.textContent).toContain("Blue"); | ||
| expect(li.textContent).toContain("Red"); | ||
| expect(li.textContent).toContain("wasteland"); | ||
| expect(li.textContent).toBe("Rose"); | ||
| const [p1, p2, p3] = [...doc.querySelectorAll("#test p")]; | ||
| expect(p1.textContent).toContain("Blue"); | ||
| expect(p2.textContent).toContain("Red"); | ||
| expect(p3.textContent).toContain("wasteland"); |
There was a problem hiding this comment.
See markedjs/marked#1934 (and the fix: markedjs/marked#1936)
cc: @saschanaz (don't know if this test was intentional as such)
There was a problem hiding this comment.
The intention here was to wrap them to li. It seems marked now requires at least 3-space indentation here.
There was a problem hiding this comment.
3-space fixes it. Shouldn't be a breaking change for us as we've delegated markdown related changes on marked, which is commonmark compliant (almost).
Thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #3355
Closes #3354
Closes #3353
Closes #3352
Closes #3351
Closes #3350