Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(useScrollLock): detect parent with overflow auto #2699

Merged
merged 1 commit into from Feb 18, 2023
Merged

fix(useScrollLock): detect parent with overflow auto #2699

merged 1 commit into from Feb 18, 2023

Conversation

dpschen
Copy link
Contributor

@dpschen dpschen commented Jan 30, 2023 •
edited

Description

This PR adds a condition to the checkOverflowScroll function for elements that have an overflow value that is auto.

See: #2362 (comment)

What is the purpose of this pull request?

  • Bug fix
  • New Feature
  • Documentation update
  • Other

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.

@dpschen dpschen marked this pull request as ready for review February 1, 2023 14:39
@webfansplz webfansplz changed the title feat(useScrollLock): detect parent with overflow auto fix(useScrollLock): detect parent with overflow auto Feb 18, 2023
@antfu antfu added the direction: approved The direction of feature/change is approved by the team. May require some small changes. label Feb 18, 2023
@webfansplz webfansplz merged commit 7e5901e into vueuse:main Feb 18, 2023
@antfu antfu modified the milestone: 10.0 Feb 18, 2023
@dpschen dpschen deleted the patch-1 branch February 20, 2023 14:50
@dpschen dpschen mentioned this pull request Mar 1, 2023
Closed
7 tasks
@valerypatorius valerypatorius mentioned this pull request May 5, 2023
Merged
5 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@webfansplz webfansplz webfansplz approved these changes

Assignees
No one assigned
Labels
direction: approved The direction of feature/change is approved by the team. May require some small changes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dpschen @webfansplz @antfu