Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(useScrollLock): fix scrollable children check #3065

Merged
merged 1 commit into from May 9, 2023
Merged

fix(useScrollLock): fix scrollable children check #3065

merged 1 commit into from May 9, 2023

Conversation

valerypatorius
Copy link
Contributor

@valerypatorius valerypatorius commented May 5, 2023

Before submitting the PR, please make sure you do the following

  • Read the Contributing Guidelines.
  • Read the Pull Request Guidelines.
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Ideally, include relevant tests that fail without this PR but pass with it.
⚠️ Slowing down new functions

Warning: Slowing down new functions

As the VueUse audience continues to grow, we have been inundated with an overwhelming number of feature requests and pull requests. As a result, maintaining the project has become increasingly challenging and has stretched our capacity to its limits. As such, in the near future, we may need to slow down our acceptance of new features and prioritize the stability and quality of existing functions. Please note that new features for VueUse may not be accepted at this time. If you have any new ideas, we suggest that you first incorporate them into your own codebase, iterate on them to suit your needs, and assess their generalizability. If you strongly believe that your ideas are beneficial to the community, you may submit a pull request along with your use cases, and we would be happy to review and discuss them. Thank you for your understanding.


Description

Scrollable elements check, which has been implemented in #2699, was not working properly, as element's heights were comparing in case of horizontal scroll and widths were comparing in case of vertical scroll. So the check did not pass if an element had vertical scroll, because its clientWidth and scrollWidth remained equal

Additional context

Scroll was not working inside scrollable children with overflow-x: hidden; overflow-y: auto; properties


🤖 Generated by Copilot at c4d7a86

Fixed a bug in useScrollLock hook that caused incorrect behavior for elements with only horizontal scroll. Swapped the order of overflow scroll checks in useScrollLock/index.ts.

🤖 Generated by Copilot at c4d7a86

  • Swap the order of checking horizontal and vertical scroll overflow in isScrollable function (link) to fix a bug in useScrollLock hook

@antfu antfu enabled auto-merge (squash) May 9, 2023 09:29
@antfu antfu merged commit cdc2861 into vueuse:main May 9, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants