Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pnpm support and compatble with latest vp2 #1731

Closed
wants to merge 18 commits into from
Closed

Conversation

Mister-Hope
Copy link
Member

@Mister-Hope Mister-Hope commented Apr 28, 2022

Note: This PR is currectly blocked by a VuePress bug vuepress/core#866

  • Switch to pnpm
  • Refine plugin api
  • Add pnpm install command in install part
  • Update plugin usage docs
  • Update theme usage docs
  • Improve docs with new changes
  • Update ci, drop node 12, add node 18 and use pnpm
  • Update contributing guide
  • Update demo
  • Update template
  • Add pnpm support for create package
  • Update cookbook
  • Update packages readme
  • Rename and refine helpers
  • Update migration guide
  • Update how to apply search plugin
  • Update release script
  • Compatble with latest webpack bundler
  • Compatble with latest vite bundler: [Bug report] Failed to use any non-ssr friendly package in client side vuepress/core#866

@gitguardian
Copy link

gitguardian bot commented Apr 28, 2022

⚠️ GitGuardian has uncovered 33 secrets following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secrets in your pull request
GitGuardian id Secret Commit Filename
2679276 Generic High Entropy Secret 2fc4686 docs/add-this/src/.vuepress/config.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/add-this/src/.vuepress/theme.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/blog2/src/.vuepress/config.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/blog2/src/.vuepress/theme.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/comment2/src/.vuepress/config.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/comment2/src/.vuepress/theme.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/components/src/.vuepress/config.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/components/src/.vuepress/theme.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/copy-code2/src/.vuepress/config.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/copy-code2/src/.vuepress/theme.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/copyright2/src/.vuepress/config.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/copyright2/src/.vuepress/theme.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/feed2/src/.vuepress/config.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/feed2/src/.vuepress/theme.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/lightgallery/src/.vuepress/config.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/lightgallery/src/.vuepress/theme.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/md-enhance/src/.vuepress/config.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/md-enhance/src/.vuepress/theme.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/photo-swipe/src/.vuepress/config.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/photo-swipe/src/.vuepress/theme.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/pwa2/src/.vuepress/config.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/pwa2/src/.vuepress/theme.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/reading-time2/src/.vuepress/config.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/redirect2/src/.vuepress/config.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/redirect2/src/.vuepress/theme.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/sass-palette/src/.vuepress/config.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/sass-palette/src/.vuepress/theme.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/seo2/src/.vuepress/config.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/seo2/src/.vuepress/theme.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/sitemap2/src/.vuepress/config.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/sitemap2/src/.vuepress/theme.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/theme/src/.vuepress/config.ts View secret
2679276 Generic High Entropy Secret 2fc4686 docs/theme/src/.vuepress/theme.ts View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secrets safely. Learn here the best practices.
  3. Revoke and rotate these secrets.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@codecov
Copy link

codecov bot commented Apr 29, 2022

Codecov Report

Merging #1731 (de726a0) into main (fef1ed7) will decrease coverage by 0.15%.
The diff coverage is 50.00%.

❗ Current head de726a0 differs from pull request most recent head 4a15fe7. Consider uploading reports for the commit 4a15fe7 to get more accurate results

@@            Coverage Diff             @@
##             main    #1731      +/-   ##
==========================================
- Coverage   76.95%   76.79%   -0.16%     
==========================================
  Files          52       52              
  Lines        1332     1336       +4     
  Branches      500      504       +4     
==========================================
+ Hits         1025     1026       +1     
- Misses        289      292       +3     
  Partials       18       18              
Impacted Files Coverage Δ
packages/shared/src/node/locales/helpers.ts 68.75% <50.00%> (-3.98%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fef1ed7...4a15fe7. Read the comment docs.

@lgtm-com
Copy link

lgtm-com bot commented May 1, 2022

This pull request introduces 1 alert when merging 82401c3 into 1401242 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@lgtm-com
Copy link

lgtm-com bot commented May 1, 2022

This pull request introduces 1 alert when merging 49743cf into 1401242 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@Mister-Hope Mister-Hope marked this pull request as draft May 1, 2022 19:17
@lgtm-com
Copy link

lgtm-com bot commented May 1, 2022

This pull request introduces 1 alert when merging 003c4c9 into 1401242 - view on LGTM.com

new alerts:

  • 1 for Unused variable, import, function or class

@Mister-Hope Mister-Hope force-pushed the refactor branch 3 times, most recently from b67fd7f to ef6d8c3 Compare May 2, 2022 05:14
@Mister-Hope Mister-Hope closed this May 3, 2022
@Mister-Hope Mister-Hope deleted the refactor branch May 17, 2022 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Not compatable with vuepress@2.0.0-beta.40+
1 participant