Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Bug report] logoDark src property take the logo src property #1729

Closed
3 of 5 tasks
DjCodeGit opened this issue Apr 28, 2022 · 2 comments
Closed
3 of 5 tasks

[Bug report] logoDark src property take the logo src property #1729

DjCodeGit opened this issue Apr 28, 2022 · 2 comments
Assignees
@Mister-Hope
Labels
bug Something isn't working

Comments

@DjCodeGit
Copy link

Checklist

  • I am using the latest version
  • I have searched FAQ (V1 Docs | V2 Docs)

Package name

vuepress-theme-hope

Version

v2

Which operating system are you using?

  • macOS
  • Windows
  • Linux

Describe the bug

Hello ,
you have a mistake in the module "NavbarBrand.ts". The src property of logoDark take the value of src property of the logo.

See you below the correction
bug logoDark

Additional context

No response
@DjCodeGit DjCodeGit added the bug Something isn't working label Apr 28, 2022
@Mister-Hope
Copy link
Member

Mister-Hope commented Apr 28, 2022 •
edited

Bug confirmed, thanks for pointing out.

Currently new verions are blocked by #1731, and #1731 is blocked by vuepress/core#795, so please be patient.

You can currently make a workaround with https://vuepress-theme-hope.github.io/v2/cookbook/advanced/replace.html#replace-components

@Mister-Hope Mister-Hope added the v2 label Apr 28, 2022
@Mister-Hope
Copy link
Member

Fixed in 1df15f0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Mister-Hope Mister-Hope

Labels
bug Something isn't working
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@Mister-Hope @DjCodeGit