chore: move yorkie from cli-service to plugin-eslint & plugin-typescript #4153
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It is because yorkie is not used anywhere in @vue/cli-service, but only included for the `lintOn: 'commit'` feature of eslint & typescript plugin. Also, a lot of global installation issues are caused by the yorkie postinstall script. Moving it out of the dependency chain of `@vue/cli` mitigates such issues.
sodatea
added a commit
that referenced
this pull request
Jun 24, 2019
…ipt (#4153) It is because yorkie is not used anywhere in @vue/cli-service, but only included for the `lintOn: 'commit'` feature of eslint & typescript plugin. Also, a lot of global installation issues are caused by the yorkie postinstall script. Moving it out of the dependency chain of `@vue/cli` mitigates such issues. (cherry picked from commit 271bf39)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is because yorkie is not used anywhere in @vue/cli-service, but only
included for the
lintOn: 'commit'feature of eslint & typescriptplugin.
Also, a lot of global installation issues are caused by the yorkie
postinstall script. Moving it out of the dependency chain of
@vue/climitigates such issues.