Skip to content

Commit

Permalink
chore: move yorkie from cli-service to plugin-eslint & plugin-typescr…
Browse files Browse the repository at this point in the history
…ipt (#4153)

It is because yorkie is not used anywhere in @vue/cli-service, but only
included for the `lintOn: 'commit'` feature of eslint & typescript
plugin.

Also, a lot of global installation issues are caused by the yorkie
postinstall script. Moving it out of the dependency chain of `@vue/cli`
mitigates such issues.
  • Loading branch information
sodatea committed Jun 18, 2019
1 parent 070b2e4 commit 271bf39
Show file tree
Hide file tree
Showing 3 changed files with 5 additions and 4 deletions.
3 changes: 2 additions & 1 deletion packages/@vue/cli-plugin-eslint/package.json
Expand Up @@ -26,7 +26,8 @@
"@vue/cli-shared-utils": "^4.0.0-alpha.1",
"eslint-loader": "^2.1.2",
"globby": "^9.2.0",
"webpack": ">=4 < 4.29"
"webpack": ">=4 < 4.29",
"yorkie": "^2.0.0"
},
"peerDependencies": {
"eslint": ">= 1.6.0"
Expand Down
3 changes: 2 additions & 1 deletion packages/@vue/cli-plugin-typescript/package.json
Expand Up @@ -29,7 +29,8 @@
"globby": "^9.2.0",
"ts-loader": "^6.0.1",
"tslint": "^5.16.0",
"webpack": ">=4 < 4.29"
"webpack": ">=4 < 4.29",
"yorkie": "^2.0.0"
},
"peerDependencies": {
"typescript": ">=2"
Expand Down
3 changes: 1 addition & 2 deletions packages/@vue/cli-service/package.json
Expand Up @@ -77,8 +77,7 @@
"webpack-bundle-analyzer": "^3.3.2",
"webpack-chain": "^6.0.0",
"webpack-dev-server": "^3.4.1",
"webpack-merge": "^4.2.1",
"yorkie": "^2.0.0"
"webpack-merge": "^4.2.1"
},
"peerDependencies": {
"vue-template-compiler": "^2.0.0"
Expand Down

0 comments on commit 271bf39

Please sign in to comment.