Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: mention caveat about missing plugins when in legacy config #3857

Merged
merged 2 commits into from Jun 22, 2019
Merged

docs: mention caveat about missing plugins when in legacy config #3857

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6c64090
docs: mention caveat about missing plugins
LinusBorg Apr 20, 2019
7d65762
Update browser-compatibility.md
LinusBorg Jun 22, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/guide/browser-compatibility.md
View file
Open in desktop
Expand Up @@ -89,6 +89,12 @@ Vue CLI uses two environment variables to communicate this:
**Important:** These variables are only accessible when/after `chainWebpack()` and `configureWebpack()` functions are evaluated, (so not directly in the `vue.config.js` module's root scope). That means it's also available in the postcss config file.
:::

::: warning Caveat: Adjusting webpack plugins
Some Plugins, i.e. `html-webpack-plugin`, `preload-plugin` etc. are only included in the config for modern mode. Trying to tap into their options in the legacy config can s an error as the plugins don't exist.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can s an error - what does s stands for here? 😅

Copy link
Member Author

@LinusBorg LinusBorg Jun 22, 2019 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good question, I can't exactly recall but I think it would have been something like "throw an error".

that's what this sentence is about, will change it.


Use the above tip about *Detecting the Current Mode* to manipulate plugins in the right mode only, and/or check if the plugin actually exists in the current mode's config before trying to tap into their options.
:::

[autoprefixer]: https://github.com/postcss/autoprefixer
[babel-preset-env]: https://new.babeljs.io/docs/en/next/babel-preset-env.html
[babel-preset-app]: https://github.com/vuejs/vue-cli/tree/dev/packages/%40vue/babel-preset-app
Expand Down