docs: mention caveat about missing plugins when in legacy config #3857
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when in legacy config close #3845
LinusBorg
changed the title
docs/guide/browser-compatibility.md
Outdated
| @@ -89,6 +89,12 @@ Vue CLI uses two environment variables to communicate this: | |||
| **Important:** These variables are only accessible when/after `chainWebpack()` and `configureWebpack()` functions are evaluated, (so not directly in the `vue.config.js` module's root scope). That means it's also available in the postcss config file. | |||
| ::: | |||
|
|
|||
| ::: warning Caveat: Adjusting webpack plugins | |||
| Some Plugins, i.e. `html-webpack-plugin`, `preload-plugin` etc. are only included in the config for modern mode. Trying to tap into their options in the legacy config can s an error as the plugins don't exist. | |||
There was a problem hiding this comment.
can s an error - what does s stands for here? 😅
There was a problem hiding this comment.
Good question, I can't exactly recall but I think it would have been something like "throw an error".
that's what this sentence is about, will change it.
NataliaTepluhina
approved these changes
Jun 22, 2019
There was a problem hiding this comment.
Thanks for adding this warning, @LinusBorg! I think it's really useful 👍
Added a minor grammar comment 😅
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We don't include some plugins during legacy build when building in modern mode. Trying to tap into their options causes
webpack-chainto throw a pretty cryptic error.This warning should help people deal with that situation.
close #3845