Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ssr): Using teleport disabled causes mismatch #9399

Merged
merged 3 commits into from Oct 21, 2023

Conversation

pikax
Copy link
Member

@pikax pikax commented Oct 13, 2023

closes #6152

When hydrating a teleport inside a component will cause the warning Hydration completed but contains mismatches., caused because the lookhead of teleport start was based on being always the next sibling when teleport is disabled the next sibling is the content.

@github-actions
Copy link

github-actions bot commented Oct 13, 2023

Size Report

Bundles

File Size Gzip Brotli
runtime-dom.global.prod.js 85.9 kB (+26 B) 32.7 kB (+9 B) 29.5 kB (+36 B)
vue.global.prod.js 132 kB (+26 B) 49.4 kB (+10 B) 44.3 kB (-3 B)

Usages

Name Size Gzip Brotli
createApp 47.9 kB 18.9 kB 17.2 kB
createSSRApp 50.7 kB (+26 B) 20 kB (+10 B) 18.2 kB (+14 B)
defineCustomElement 50.3 kB 19.7 kB 18 kB
overall 61.3 kB 23.7 kB 21.6 kB

@pikax pikax added ❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. scope: ssr scope: teleport labels Oct 13, 2023
@pikax
Copy link
Member Author

pikax commented Oct 13, 2023

/ecosystem-ci run

@vue-bot
Copy link

vue-bot commented Oct 13, 2023

📝 Ran ecosystem CI: Open

suite result latest scheduled
language-tools success success
nuxt failure success
pinia success failure
quasar failure failure
router success success
test-utils success success
vant success success
vite-plugin-vue success success
vitepress success success
vue-i18n success success
vue-macros failure failure
vuetify success success
vueuse success success
vue-simple-compiler success success

@sxzz sxzz added the ready for review This PR requires more reviews label Oct 14, 2023
@yyx990803 yyx990803 force-pushed the pikax/disable_teleport_inside_ssr branch from cf272e8 to a1b491d Compare October 21, 2023 03:34
@yyx990803 yyx990803 merged commit d8990fc into main Oct 21, 2023
11 checks passed
@yyx990803 yyx990803 deleted the pikax/disable_teleport_inside_ssr branch October 21, 2023 03:37
lumozx pushed a commit to lumozx/core that referenced this pull request Oct 21, 2023
@netlify
Copy link

netlify bot commented Oct 21, 2023

Deploy Preview for vue-sfc-playground failed.

Name Link
🔨 Latest commit cf272e8
🔍 Latest deploy log https://app.netlify.com/sites/vue-sfc-playground/deploys/6533468412b87c0008b7acae

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
❗ p4-important Priority 4: this fixes bugs that violate documented behavior, or significantly improves perf. ready for review This PR requires more reviews scope: ssr scope: teleport
Projects
Development

Successfully merging this pull request may close these issues.

Disabled teleport inside fragment causes SSR hydration mismatches
5 participants