Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Teleport disabled workaround tracker #1523

Closed
VividLemon opened this issue Oct 16, 2023 · 3 comments
Closed

Teleport disabled workaround tracker #1523

VividLemon opened this issue Oct 16, 2023 · 3 comments
Labels
stale-exempt Use this to prevent auto-stalling of an issue

Comments

@VividLemon
Copy link
Member

vuejs/core#6152
&
vuejs/core#9399

@VividLemon VividLemon added the stale-exempt Use this to prevent auto-stalling of an issue label Oct 16, 2023
@VividLemon
Copy link
Member Author

@xvaara vuejs/core#9399 was merged . Do you mind checking to see if it works, and removing the hack so we can close this?

@xvaara
Copy link
Contributor

xvaara commented Nov 6, 2023

I tested the current main and vue 3.3.8 and ssr with teleport works. So yes it works.

@xvaara xvaara closed this as completed Nov 6, 2023
@VividLemon
Copy link
Member Author

VividLemon commented Nov 6, 2023

@xvaara Do you want to go in and unify the Teleport props?

Perhaps

export interface TeleportProps {
    teleportTo?: ///
    teleportDisabled?: ///
}

I'd do it, but I'm not sure how to reconcile the differences between things like BPopover where it declares "container" instead of "teleportTo", in addition to its "disabled" counterpart

Also naturally the peer dependency should be updated

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale-exempt Use this to prevent auto-stalling of an issue
Projects
None yet
Development

No branches or pull requests

2 participants