Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(compiler-core): simple identifier should include Chinese #10575

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(compiler-core): simple identifier should include Chinese #10575

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
911b959
fix(compiler-core): simple identifier should include Chinese
wangyewei Mar 23, 2024
4902f9b
test(compiler-core): add unit test in `v-on`
wangyewei Mar 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion packages/compiler-core/src/utils.ts
View file
Open in desktop
Expand Up @@ -62,7 +62,7 @@ export function isCoreComponent(tag: string): symbol | void {
}
}

const nonIdentifierRE = /^\d|[^\$\w]/
const nonIdentifierRE = /^\d|[^\$\w\u4e00-\u9fa5]/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please add unit test 😁

export const isSimpleIdentifier = (name: string): boolean =>
!nonIdentifierRE.test(name)
Comment on lines +65 to 67
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we can refactor this part by using propNameEscapeSymbolsRE (move it to shared pkg)

core/packages/compiler-sfc/src/script/utils.ts

Line 110 in caeb8a6

export const propNameEscapeSymbolsRE = /[ !"#$%&'()*+,./:;<=>?@[\\\]^`{|}~\-]/

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems that directly use this regx to instead will break other test units


Expand Down