New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(compiler-core): simple identifier should include Chinese #10575
base: main
Are you sure you want to change the base?
Conversation
Size ReportBundles
Usages
|
@@ -62,7 +62,7 @@ export function isCoreComponent(tag: string): symbol | void { | |||
} | |||
} | |||
|
|||
const nonIdentifierRE = /^\d|[^\$\w]/ | |||
const nonIdentifierRE = /^\d|[^\$\w\u4e00-\u9fa5]/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add unit test 😁
duplicate of #6765 |
const nonIdentifierRE = /^\d|[^\$\w\u4e00-\u9fa5]/ | ||
export const isSimpleIdentifier = (name: string): boolean => | ||
!nonIdentifierRE.test(name) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we can refactor this part by using propNameEscapeSymbolsRE
(move it to shared
pkg)
export const propNameEscapeSymbolsRE = /[ !"#$%&'()*+,./:;<=>?@[\\\]^`{|}~\-]/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
seems that directly use this regx to instead will break other test units
close #10542