feat: 馃幐 add ramda and test-tools import messages #42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
klzns
suggested changes
Jan 31, 2020
| @@ -39,6 +39,7 @@ | |||
| "postinstall": "lerna bootstrap && yarn build && lerna link" | |||
| }, | |||
| "devDependencies": { | |||
| "@geut/chan": "^2.1.1", | |||
There was a problem hiding this comment.
馃ぃ util to add changes to the changelog following the keep a changelog pattern. It was already being used in the project, I just forgot to add it to the deps https://github.com/geut/chan/tree/master/packages/chan
klzns
approved these changes
Feb 3, 2020
kaisermann
added a commit
that referenced
this pull request
Feb 3, 2020
* feat: 馃幐 add ramda and test-tools import messages * chore: 馃 update changelog and add chan dep * chore: 馃 remove wrong ci task
kaisermann
added a commit
that referenced
this pull request
Feb 3, 2020
* feat: 馃幐 add ramda and test-tools import messages * chore: 馃 update changelog and add chan dep * chore: 馃 remove wrong ci task
kaisermann
added a commit
that referenced
this pull request
Feb 3, 2020
* feat: 馃幐 add ramda and test-tools import messages * chore: 馃 update changelog and add chan dep * chore: 馃 remove wrong ci task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the purpose of this pull request?
Add recommendation messages for restricted imports (
@testing-library/reactandlodash).Screenshots or example usage
Unfortunately, currently eslint doesn't support adding messages to a
patternrestriction, solodash/*is not as nice as it could be. There's an open issue about this here. We could probably help implement this, seems easy enough. Do we wait for that?Closes #13
Types of changes