feat: 🎸 add ramda and test-tools import messages (#42)

* feat: 🎸 add ramda and test-tools import messages * chore: 🤖 update changelog and add chan dep * chore: 🤖 remove wrong ci task
vtex · Feb 3, 2020 · fe023ec · fe023ec
1 parent 986a762
commit fe023ec
Show file tree

Hide file tree

Showing 4 changed files with 19 additions and 16 deletions.
diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml
@@ -9,17 +9,3 @@ jobs:
       - uses: actions/checkout@v1
       - uses: actions/setup-node@v1
       - run: yarn && yarn lint
-
-  Tests:
-    needs: [Lint]
-    runs-on: ubuntu-latest
-    steps:
-      - run: git config --global core.autocrlf false
-      - uses: actions/checkout@v1
-      - uses: actions/setup-node@v1
-        with:
-          node-version: 12
-      - run: yarn
-      - run: cd node && yarn && yarn test
-        env:
-          CI: true
diff --git a/package.json b/package.json
@@ -39,6 +39,7 @@
     "postinstall": "lerna bootstrap && yarn build && lerna link"
   },
   "devDependencies": {
+    "@geut/chan": "^2.1.1",
     "eslint": "^6.7.0",
     "husky": "^4.2.0",
     "lerna": "^3.18.4",

diff --git a/packages/eslint-config-vtex/CHANGELOG.md b/packages/eslint-config-vtex/CHANGELOG.md
@@ -6,6 +6,10 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 
 ## [Unreleased]
 
+## [12.0.4] - 2020-02-03
+### Added
+- Add warning message for lodash and @testing-library imports.
+
 ## [12.0.3] - 2020-01-24
 ### Fixed
 - Changelog on deploy workflow again.
@@ -73,7 +77,8 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.
 ### Changed
 - Lodash rules and prettier configs.
 
-[Unreleased]: https://github.com/vtex/js-standards/compare/v12.0.3...HEAD
+[Unreleased]: https://github.com/vtex/js-standards/compare/v12.0.4...HEAD
+[12.0.4]: https://github.com/vtex/js-standards/compare/v12.0.3...v12.0.4
 [12.0.3]: https://github.com/vtex/js-standards/compare/v12.0.2...v12.0.3
 [12.0.2]: https://github.com/vtex/js-standards/compare/v12.0.1...v12.0.2
 [12.0.1]: https://github.com/vtex/js-standards/compare/v12.0.0...v12.0.1
diff --git a/packages/eslint-config-vtex/rules/imports.js b/packages/eslint-config-vtex/rules/imports.js
@@ -8,7 +8,18 @@ module.exports = {
     'no-restricted-imports': [
       'error',
       {
-        paths: ['lodash'],
+        paths: [
+          {
+            name: 'lodash',
+            message: "Please use 'ramda' instead",
+          },
+          {
+            name: '@testing-library/react',
+            message: "Please use '@vtex/test-tools/react' instead",
+          },
+        ],
+        // Patterns don't support messages yet :(
+        // https://github.com/eslint/eslint/issues/11843
         patterns: ['lodash/*'],
       },
     ],