Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js version of CI runtime and storybook #1007

Merged
merged 3 commits into from Sep 29, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions .github/workflows/check.yaml
Expand Up @@ -8,10 +8,10 @@ jobs:
runs-on: ubuntu-latest
steps:
- uses: actions/checkout@v3
- name: Use Node.js 16.x
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: install
run: make -f ci.mk install
- name: lint
Expand Down
4 changes: 2 additions & 2 deletions .github/workflows/release.yaml
Expand Up @@ -16,10 +16,10 @@ jobs:
ref: ${{ github.event.ref }}
- name: Unshallow
run: git fetch --prune --unshallow --tags
- name: Use Node.js 16.x
- name: Use Node.js 18.x
uses: actions/setup-node@v3
with:
node-version: 16.x
node-version: 18.x
- name: install
run: make -f ci.mk install
- name: lint
Expand Down
3 changes: 3 additions & 0 deletions .storybook/main.js
Expand Up @@ -27,4 +27,7 @@ module.exports = {
...options,
plugins: [["@babel/plugin-proposal-class-properties", { loose: true }]],
}),
core: {
builder: "webpack5",
},
Comment on lines +30 to +32
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

};
4 changes: 3 additions & 1 deletion package.json
Expand Up @@ -9,7 +9,7 @@
"module": "dist/index.es.js",
"jsnext:main": "dist/index.es.js",
"engines": {
"node": "^14.18.1 || >=16.0.0"
"node": "^16.x || >=18.0.0"
},
"scripts": {
"test": "cross-env CI=1 jest --runInBand",
Expand Down Expand Up @@ -47,6 +47,8 @@
"@storybook/addon-links": "6.5.9",
"@storybook/addon-postcss": "2.0.0",
"@storybook/addon-storysource": "6.5.9",
"@storybook/builder-webpack5": "6.5.12",
"@storybook/manager-webpack5": "6.5.12",
"@storybook/react": "6.5.9",
"@svgr/rollup": "6.3.1",
"@testing-library/jest-dom": "5.16.4",
Expand Down