Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Node.js version of CI runtime and storybook #1007

Merged
merged 3 commits into from Sep 29, 2022

Conversation

takurinton
Copy link
Contributor

No description provided.

@netlify
Copy link

netlify bot commented Sep 28, 2022

Deploy Preview for ingred-ui ready!

Name Link
🔨 Latest commit 36687fa
🔍 Latest deploy log https://app.netlify.com/sites/ingred-ui/deploys/63352aefa6382600091347b2
😎 Deploy Preview https://deploy-preview-1007--ingred-ui.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

@takurinton
Copy link
Contributor Author

storybook の build が通らなかったので plugin を刺して対応した。
build 自体は通るし dev server も起動するけど warning がたくさんでる、これのせいっぽい。
storybookjs/storybook#19055

@takurinton
Copy link
Contributor Author

Netlify がこけるのは ingred-ui チームからするともうどうしようもないので対応を待つしかないって感じ。

@takurinton takurinton changed the title Update Node.js version Update Node.js version of CI runtime and storybook Sep 29, 2022
@takurinton
Copy link
Contributor Author

これでデプロイはできると思う
一旦 netlify はスルーして、それ以外の部分(CI, ローカルでの storybook 起動)を 18 対応させておく。

Comment on lines +30 to +32
core: {
builder: "webpack5",
},
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@takurinton takurinton merged commit 5294c26 into master Sep 29, 2022
@takurinton takurinton deleted the update-nodejs-version branch September 29, 2022 05:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants