Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

App supports bazel #3338

Merged
merged 42 commits into from Jul 25, 2023
Merged

Conversation

mys007
Copy link
Contributor

@mys007 mys007 commented Jul 25, 2023

What changes are proposed in this pull request?

When fiftyone is installed under bazel environment and fo.launch_app() is called, the App does not launch and only 404 is displayed.

This is because bazel creates virtual package installations, where everything - including fiftyone/server/static - is just a symbolic link to a central, shared location. The story with bazel is also mentioned in encode/starlette#1083 and was one of the motivation for introducing StaticFiles(follow_symlink=True) for this purpose.

This PR turns on the support for symlinks for the static directory, so that fiftyone works with bazel.

How is this patch tested? If it is not, please explain why.

Tested locally.

Release Notes

Is this a user-facing change that should be mentioned in the release notes?

  • No. You can skip the rest of this section.
  • Yes. Give a description of this change to be included in the release
    notes for FiftyOne users.

(Details in 1-2 sentences. You can just refer to another PR with a description
if this PR is part of a larger change.)

What areas of FiftyOne does this PR affect?

  • App: FiftyOne application changes
  • Build: Build and test infrastructure changes
  • Core: Core fiftyone Python library changes
  • Documentation: FiftyOne documentation changes
  • Other

Copy link
Contributor

@benjaminpkane benjaminpkane left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks @mys007!

@codecov
Copy link

codecov bot commented Jul 25, 2023

Codecov Report

Patch and project coverage have no change.

Comparison is base (5a929eb) 15.48% compared to head (ee2001b) 15.48%.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3338   +/-   ##
========================================
  Coverage    15.48%   15.48%           
========================================
  Files          569      569           
  Lines        70351    70351           
  Branches       687      687           
========================================
  Hits         10895    10895           
  Misses       59456    59456           
Flag Coverage Δ
app 15.48% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@brimoor brimoor changed the base branch from develop to release/v0.21.5 July 25, 2023 22:42
@brimoor brimoor merged commit 2fff979 into voxel51:release/v0.21.5 Jul 25, 2023
8 of 11 checks passed
@mys007 mys007 deleted the server-app-bazel-support branch July 27, 2023 11:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants