Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert follow symlinks in static #3439

Merged
merged 1 commit into from
Aug 29, 2023
Merged

Revert follow symlinks in static #3439

merged 1 commit into from
Aug 29, 2023

Conversation

benjaminpkane
Copy link
Contributor

@benjaminpkane benjaminpkane commented Aug 22, 2023

Resolves #3424

Reverts the change in #3338 as it is causing 404 issues on some existing installations

@benjaminpkane benjaminpkane added bug Bug fixes server Issues related to server features or changes labels Aug 22, 2023
@benjaminpkane benjaminpkane self-assigned this Aug 22, 2023
@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Patch coverage has no change and project coverage change: -0.01% ⚠️

Comparison is base (2f7b22a) 16.00% compared to head (e33349b) 15.99%.
Report is 27 commits behind head on develop.

Additional details and impacted files
@@             Coverage Diff             @@
##           develop    #3439      +/-   ##
===========================================
- Coverage    16.00%   15.99%   -0.01%     
===========================================
  Files          572      572              
  Lines        71213    71235      +22     
  Branches       800      800              
===========================================
  Hits         11397    11397              
- Misses       59816    59838      +22     
Flag Coverage Δ
app 15.99% <0.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
...ckages/components/src/components/Header/Header.tsx 39.02% <0.00%> (ø)
...ackages/core/src/components/Actions/ActionsRow.tsx 0.00% <0.00%> (ø)
...pp/packages/core/src/components/Actions/Common.tsx 0.00% <0.00%> (ø)
.../packages/core/src/components/Actions/Selected.tsx 0.00% <0.00%> (ø)
...pp/packages/core/src/components/Actions/Tagger.tsx 0.00% <0.00%> (ø)
...kages/core/src/components/Common/CountSubcount.tsx 0.00% <0.00%> (ø)
...ackages/core/src/components/Common/RangeSlider.tsx 0.00% <0.00%> (ø)
...core/src/components/Filters/NumericFieldFilter.tsx 0.00% <0.00%> (ø)
...ts/Filters/categoricalFilter/CategoricalFilter.tsx 0.00% <0.00%> (ø)
...c/components/Filters/categoricalFilter/Wrapper.tsx 0.00% <0.00%> (ø)
... and 14 more

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@benjaminpkane benjaminpkane changed the title Revet follow symlinks in static Revert follow symlinks in static Aug 22, 2023
@benjaminpkane benjaminpkane marked this pull request as ready for review August 24, 2023 22:43
@sashankaryal sashankaryal self-requested a review August 28, 2023 15:51
Copy link
Contributor

@sashankaryal sashankaryal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@benjaminpkane benjaminpkane merged commit 83db4d5 into develop Aug 29, 2023
9 of 11 checks passed
@benjaminpkane benjaminpkane deleted the revert-symlinks branch August 29, 2023 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Bug fixes server Issues related to server features or changes
Projects
None yet
2 participants