Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move config into context #209

Merged
merged 1 commit into from Apr 21, 2022
Merged

Commits on Apr 19, 2022

  1. Move config into context

    Reconcilers and sub reconcilers use the config object to centralize
    common api operations. Previously this config was passed to each
    reconciler when it was initialized. However, this makes it harder to
    dynamically swap the config at runtime based on the content of a
    resource. For example, a resource may specify a service account to use
    when creating other resources with least privilege.
    
    The ChildReconciler and SyncReconciler no long allow the Config to be
    specified directly. It must be passed in via the context. So that the
    RetrieveConfig method can return the Config.
    
    SubReconcilers that need to interact with the parent resource should use
    the parent config via RetrieveParentConfig method. In many cases the
    config and parent config are one in the same, however, the WithConfig
    sub reconciler can inject an alternate config for the nested sub
    reconcilers.
    
    Signed-off-by: Scott Andrews <andrewssc@vmware.com>
    scothis committed Apr 19, 2022
    Copy the full SHA
    eaf3752 View commit details
    Browse the repository at this point in the history