Move config into context #209
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Reconcilers and sub reconcilers use the config object to centralize common api operations. Previously this config was passed to each reconciler when it was initialized. However, this makes it harder to dynamically swap the config at runtime based on the content of a resource. For example, a resource may specify a service account to use when creating other resources with least privilege. The ChildReconciler and SyncReconciler no long allow the Config to be specified directly. It must be passed in via the context. So that the RetrieveConfig method can return the Config. SubReconcilers that need to interact with the parent resource should use the parent config via RetrieveParentConfig method. In many cases the config and parent config are one in the same, however, the WithConfig sub reconciler can inject an alternate config for the nested sub reconcilers. Signed-off-by: Scott Andrews <andrewssc@vmware.com>
Codecov Report
@@ Coverage Diff @@
## main #209 +/- ##
==========================================
+ Coverage 61.11% 62.09% +0.98%
==========================================
Files 9 9
Lines 841 905 +64
==========================================
+ Hits 514 562 +48
- Misses 310 325 +15
- Partials 17 18 +1
Continue to review full report at Codecov.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Reconcilers and sub reconcilers use the config object to centralize
common api operations. Previously this config was passed to each
reconciler when it was initialized. However, this makes it harder to
dynamically swap the config at runtime based on the content of a
resource. For example, a resource may specify a service account to use
when creating other resources with least privilege.
The ChildReconciler and SyncReconciler no long allow the Config to be
specified directly. It must be passed in via the context. So that the
RetrieveConfig method can return the Config.
SubReconcilers that need to interact with the parent resource should use
the parent config via RetrieveParentConfig method. In many cases the
config and parent config are one in the same, however, the WithConfig
sub reconciler can inject an alternate config for the nested sub
reconcilers.
Signed-off-by: Scott Andrews andrewssc@vmware.com