refactor: BaseBone.buildDBSort
#1077
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Refactored entire code - Moved language stuff into the `BaseBone` - Support for better, talking names for "orderdir" parameter
phorward
added
feature
phorward
added
Priority: High
ArneGudermann
previously approved these changes
May 24, 2024
sveneberth
requested changes
May 24, 2024
| @@ -13,7 +13,7 @@ | |||
| from datetime import datetime, timedelta | |||
| from enum import Enum | |||
| import typing as t | |||
| from viur.core import db, utils | |||
| from viur.core import db, utils, current | |||
| from viur.core.config import conf | |||
|
|
|||
| if t.TYPE_CHECKING: | |||
There was a problem hiding this comment.
Please change the line below to
from ..skeleton import Skeleton, SkeletonInstance| def buildDBSort( | ||
| self, | ||
| name: str, | ||
| skel: 'viur.core.skeleton.SkeletonInstance', |
There was a problem hiding this comment.
Suggested change
| skel: 'viur.core.skeleton.SkeletonInstance', | |
| skel: "SkeletonInstance", |
| for item in query.queries: | ||
| new_in_eq_filter = [ | ||
| key for key in item.filters.keys() | ||
| if any(key.rstrip().endswith(op) for op in ("<", ">", "!=")) |
There was a problem hiding this comment.
Suggested change
| if any(key.rstrip().endswith(op) for op in ("<", ">", "!=")) | |
| if key.rstrip().endswith(("<", ">", "!=")) |
| if inEqFilter: | ||
| inEqFilter = inEqFilter[0][: inEqFilter[0].find(" ")] | ||
| if inEqFilter != order[0]: | ||
| logging.warning(f"I fixed you query! Impossible ordering changed to {inEqFilter}, {order[0]}") |
There was a problem hiding this comment.
I this no longer a manually developer task? 😆
Co-authored-by: Sven Eberth <mail@sveneberth.de>
phorward
commented
May 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BaseBoneutils.parse.