-
Notifications
You must be signed in to change notification settings - Fork 14
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Correct default_order
for not case-sensitive StringBone
s
#1165
Conversation
Without the `.idx` suffix an empty result is returned
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hm, indeed this is a possible fix, but on the other side the order setting should be generally handled by the bones, and not in the prototypes, like in BaseBone.buildDBSort
.
There's already pull request #1077 on this, which can be useful. Maybe it would be better to allow for a dict
here as well, which is being fed to Query.mergeExternalFilter()
, which then handles the ordering correctly?
Yeah, absolutely. After I found this bug I thought the same thing. But after looking at |
- Also allows for dict-style filter definitions as default_order - Alternative fix for viur-framework#1165
Replaced by #1169 |
- Also allows for dict-style filter definitions as default_order - Alternative fix for #1165
Without the
.idx
suffix an empty result is returned