Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(client): add on begin update hooks #623

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

Doctor-wu
Copy link

@Doctor-wu Doctor-wu commented Dec 14, 2023

Add onBeginUpdate hooks when a new service worker is found and is being installed but not yet completed.

closes #620

Copy link

netlify bot commented Dec 14, 2023

Deploy Preview for vite-plugin-pwa-legacy ready!

Name Link
🔨 Latest commit 0c777f8
🔍 Latest deploy log https://app.netlify.com/sites/vite-plugin-pwa-legacy/deploys/657f19aec5c4e60008f2483f
😎 Deploy Preview https://deploy-preview-623--vite-plugin-pwa-legacy.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

docs/frameworks/index.md Outdated Show resolved Hide resolved
@userquin userquin changed the title feat(register): add on begin update hooks feat(client): add on begin update hooks Dec 14, 2023
Copy link
Member

@userquin userquin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

thx

@userquin
Copy link
Member

can you add it to an example (don't use sveltekit, it is deprecated in this repo)?

@Doctor-wu
Copy link
Author

Done

@userquin
Copy link
Member

userquin commented Dec 14, 2023

I'm going to do some tests (no idea when I'll have some free time) and maybe adding a new experimental option to use a new built-in workbox-window exposing the updatefound event, Workbox repo is dead, just a few updates in last years.

@userquin userquin added the on hold more work to be done label Dec 18, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
on hold more work to be done
Projects
None yet
Development

Successfully merging this pull request may close these issues.

try to expose new version detected
2 participants