feat!: move client to @vite-pwa/workbox-window
#634
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for vite-plugin-pwa-legacy ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
userquin
changed the title
@vite-pwa/workbox-window@vite-pwa/workbox-window
# Conflicts: # src/client/build/register.ts
# Conflicts: # examples/vanilla-ts-no-ip/package.json # pnpm-lock.yaml # src/client/build/register.ts
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR also includes
installingevent support for VanillaJS and all frameworks:onInstallingandonUpdateFoundcallbacksinstallingSWandupdatingSWpropsI need to review if
installingSWandupdatingSWcan be read only (when exposing them), the logic should be handled internally,installingevent is a transient event.NOTE: make read-only in react/preact is almost imposible if we don't include some state management library, in svelte we'll need to add extra logic to handle writable stores (remove subcriptions), I have no idea what happens when returning only the solid accessor (the only we can use read-only is vue via readonly or computed from the ref).
NOTE: this PR should be included only in
v1.0.0major version./cc @antfu I removed
ssr.noExternalfrom main plugin,@vite-pwa/workbox-windowis ESM-first with dual ESM/CJS package exports.closes #620
supersedes #623