Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use cache for declared function when available before falling back to stubs #8503

Conversation

kkmuffme
Copy link
Contributor

fixes return type issues reported for the wrong file

Fix #8457

… stubs

fixes return type issues reported for the wrong file
@kkmuffme kkmuffme marked this pull request as ready for review September 22, 2022 00:21
@kkmuffme
Copy link
Contributor Author

Ready to be reviewed & merged :-)

@orklah orklah added the release:fix The PR will be included in 'Fixes' section of the release notes label Sep 22, 2022
@orklah orklah merged commit ebabd4b into vimeo:4.x Sep 22, 2022
@orklah
Copy link
Collaborator

orklah commented Sep 22, 2022

Thanks!

@AndrolGenhald
Copy link
Collaborator

Oh nice! I expected it to be a bit harder to fix than that.

@kkmuffme kkmuffme deleted the fix-phpdoc-errors-reported-for-stubs-instead-of-files branch September 23, 2022 11:13
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Dec 29, 2022
fixes return type issues of methods reported for the wrong file

Fix vimeo#8457

See vimeo#8503 which fixed this issue for functions
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Dec 29, 2022
fixes return type issues of methods reported for the wrong file

Fix vimeo#8457

See vimeo#8503 which fixed this issue for functions
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Dec 29, 2022
fixes return type issues of methods reported for the wrong file

Fix vimeo#8457

See vimeo#8503 which fixed this issue for functions
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Nov 15, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Nov 15, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Nov 15, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Nov 15, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Nov 15, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Nov 15, 2023
…s this didn't work correctly and lead to errors not being reported at all in many cases (since the error was reported for the stubs file and therefore suppressed)

With the previous commit "Fix for classes what vimeo#8503 fixed for functions", the stubs of classes where the actual file is in the analyzed files are ignored completely.
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Nov 15, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Nov 15, 2023
…s this didn't work correctly and lead to errors not being reported at all in many cases (since the error was reported for the stubs file and therefore suppressed)

With the previous commit "Fix for classes what vimeo#8503 fixed for functions", the stubs of classes where the actual file is in the analyzed files are ignored completely.
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Nov 16, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Nov 16, 2023
…s this didn't work correctly and lead to errors not being reported at all in many cases (since the error was reported for the stubs file and therefore suppressed)

With the previous commit "Fix for classes what vimeo#8503 fixed for functions", the stubs of classes where the actual file is in the analyzed files are ignored completely.
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Nov 16, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Nov 16, 2023
…s this didn't work correctly and lead to errors not being reported at all in many cases (since the error was reported for the stubs file and therefore suppressed)

With the previous commit "Fix for classes what vimeo#8503 fixed for functions", the stubs of classes where the actual file is in the analyzed files are ignored completely.
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Nov 16, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Nov 16, 2023
…s this didn't work correctly and lead to errors not being reported at all in many cases (since the error was reported for the stubs file and therefore suppressed)

With the previous commit "Fix for classes what vimeo#8503 fixed for functions", the stubs of classes where the actual file is in the analyzed files are ignored completely.
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Nov 16, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Nov 16, 2023
…s this didn't work correctly and lead to errors not being reported at all in many cases (since the error was reported for the stubs file and therefore suppressed)

With the previous commit "Fix for classes what vimeo#8503 fixed for functions", the stubs of classes where the actual file is in the analyzed files are ignored completely.
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Nov 18, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Nov 18, 2023
…s this didn't work correctly and lead to errors not being reported at all in many cases (since the error was reported for the stubs file and therefore suppressed)

With the previous commit "Fix for classes what vimeo#8503 fixed for functions", the stubs of classes where the actual file is in the analyzed files are ignored completely.
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Nov 18, 2023
…idn't report for other reasons, which were solved since then)
kkmuffme added a commit to kkmuffme/psalm that referenced this pull request Nov 18, 2023
…s this didn't work correctly and lead to errors not being reported at all in many cases (since the error was reported for the stubs file and therefore suppressed)

With the previous commit "Fix for classes what vimeo#8503 fixed for functions", the stubs of classes where the actual file is in the analyzed files are ignored completely.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

InvalidReturnType are reported for stubs
3 participants