Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add hideAllErrorsExceptPassedFiles config option #8502

Merged
merged 2 commits into from Sep 25, 2022
Merged

add hideAllErrorsExceptPassedFiles config option #8502

merged 2 commits into from Sep 25, 2022

Conversation

kkmuffme
Copy link
Contributor

for files only (not directories, since that wouldn't make practical sense)

Fix: #5322

@kkmuffme kkmuffme force-pushed the option-to-only-report-errors-for-passed-file branch from cbe4ba8 to 4c2ca85 Compare September 21, 2022 22:13
@kkmuffme kkmuffme marked this pull request as ready for review September 21, 2022 22:27
@kkmuffme
Copy link
Contributor Author

kkmuffme commented Sep 21, 2022 •
edited

Note for me: due to #8457 we can only use this partially for now, as otherwise those errors from stubs wouldn't report at all

Can be fully used once #8503 is merged

@kkmuffme kkmuffme force-pushed the option-to-only-report-errors-for-passed-file branch from a37bf1d to 4c2ca85 Compare September 21, 2022 22:40
@kkmuffme
Copy link
Contributor Author

Ready to be reviewed & merged :-)

@orklah
Copy link
Collaborator

orklah commented Sep 22, 2022

I'd like to have some documentation on new configs please

@kkmuffme
Copy link
Contributor Author

Me too, but I don't know where I need to add that :-) Please advise

@orklah
Copy link
Collaborator

orklah commented Sep 23, 2022

You can put that in configuration.md so it ends up here: https://psalm.dev/docs/running_psalm/configuration/

@kkmuffme
add hideAllErrorsExceptPassedFiles config option
b1c0c2d 
for files only (not directories, since that wouldn't make practical sense)
@kkmuffme
add docs
b68ac86
@kkmuffme kkmuffme force-pushed the option-to-only-report-errors-for-passed-file branch from 4c2ca85 to b68ac86 Compare September 24, 2022 08:44
@kkmuffme
Copy link
Contributor Author

Done, ready to merge

@orklah orklah added the release:feature The PR will be included in 'Features' section of the release notes label Sep 25, 2022
@orklah orklah merged commit 313ebf4 into vimeo:4.x Sep 25, 2022
@orklah
Copy link
Collaborator

orklah commented Sep 25, 2022

Thanks!

@kkmuffme kkmuffme deleted the option-to-only-report-errors-for-passed-file branch September 26, 2022 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
release:feature The PR will be included in 'Features' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Option to not report errors for required/included files
2 participants
@kkmuffme @orklah