Allow *bin2hex and *bin2base64 functions to keep non-empty-string type

[LeSuisse]

Those functions should not return a string when they receive a non-empty-string in input.

The following example is expected to work:

<?php

/**
 * @param non-empty-string $i
 */
function takesNonEmptyString(string $i): void {
    echo $i;
}

takesNonEmptyString(bin2hex("a"));
takesNonEmptyString(base64_encode("a"));

https://psalm.dev/r/0d5b2b3965

[AndrolGenhald]

I believe the sodium_* functions require an extension to be installed? Could we add a separate stub for that and conditionally include it like the other extension stubs?

[LeSuisse]

I believe the sodium_* functions require an extension to be installed? Could we add a separate stub for that and conditionally include it like the other extension stubs?

Hum maybe? I took the same approach than for the sodium_* functions that were already in the file.

[AndrolGenhald]

I took the same approach than for the sodium_* functions that were already in the file.

Well, if they're already there I guess this is fine then. Maybe I'll get around to moving them to a separate extension stub for Psalm 5.

[AndrolGenhald]

Thanks!

[staabm]

just a headsup from the review in phpstan. we don't need a template in phpstan for this case, see phpstan/phpstan-src#1664

maybe thats also the case for psalm and this can be simplified

[orklah]

yeah, same on Psalm, but stubs are transparent for users so it doesn't really matters