encoding functions returns non-empty-string

[staabm]

analog vimeo/psalm#8431

fixes https://phpstan.org/r/3a8a8430-1d4c-4bb9-99a8-f3838932f1e6

[staabm]

the error in composer is valid and it was there before this PR:

 ------ --------------------------------------------------------------------- 
  Line   src/Composer/Util/RemoteFilesystem.php                               
 ------ --------------------------------------------------------------------- 
  327    Parameter #1 $string of function base64_encode expects T of string,  
         string|false given.                                                  
 ------ --------------------------------------------------------------------- 

since the error message changed because generics are involved now, the already existing ignore-line no longer mutes it

https://github.com/ondrejmirtes/composer/blob/acef69614d5c54def3418d3964749b49923200b2/phpstan/baseline-8.1.neon#L278-L281

[ondrejmirtes]

You don't need generics for this, ($string is non-empty-string ? non-empty-string : string) should work just as well. Please edit all of these fuctions.

[staabm]

good catch, fixed.

[ondrejmirtes]

Thank you!