Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix method signatures for ReflectionProperty #7402

Closed

Conversation

derrabus
Copy link

Fixes #7357

@derrabus derrabus force-pushed the bugfix/reflection-property-set-value branch from 3ae453b to 96b6e16 Compare January 16, 2022 02:57
@derrabus
Copy link
Author

Sorry, I have no clue how to fix that test. 🙈

@AndrolGenhald
Copy link
Collaborator

@derrabus See eg #7406, there are delta callmaps for each PHP version. If the signature needs to be changed in all of them, update the historical callmap so it matches, if it needs to be changed only for some specific version onward, add the change to that delta.

@orklah
Copy link
Collaborator

orklah commented Jan 17, 2022

@derrabus no worries! We have a documentation page dedicated to those changes here: https://psalm.dev/docs/contributing/editing_callmaps/ if you need more informations. But yeah, @AndrolGenhald is right, Callmap.php is the current state of PHP8.1 but we use delta files in order to pinpoint what was the state of every other PHP version until "historical" (which is 7.0), so you need to update those too.

@orklah orklah marked this pull request as draft January 19, 2022 19:37
@weirdan
Copy link
Collaborator

weirdan commented Nov 27, 2022

4.x branch is closed now as we prepare for the 5.0 release. Please target the master branch instead.

@derrabus derrabus changed the base branch from 4.x to master November 28, 2022 10:38
@weirdan
Copy link
Collaborator

weirdan commented Feb 15, 2023

The original issue seems to be already resolved.

@weirdan weirdan closed this Feb 15, 2023
@derrabus derrabus deleted the bugfix/reflection-property-set-value branch February 15, 2023 18:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

MethodSignatureMismatch when extending ReflectionProperty
4 participants