MethodSignatureMismatch when extending ReflectionProperty

[derrabus]

ReflectionProperty::setValue() and ReflectionProperty::getValue() are polymorphic. If you work on a static property you can omit the first parameter which is the object on which you want to access the property.

The following code is valid imho:

class MyReflectionProperty extends ReflectionProperty
{
    public function getValue(?object $object = null): mixed
    {
        return parent::getValue(...func_get_args());
    }

    public function setValue(mixed $objectOrValue, mixed $value = null): void
    {
        parent::setValue(...func_get_args());
    }
}

see https://psalm.dev/r/7de1b5f18a and https://3v4l.org/Ie4oo

However, Psalm logs MethodSignatureMismatch errors. If I apply the changes suggested by those errors, I end up with code that would exit with a fatal error:

see https://3v4l.org/mX1AF

[psalm-github-bot]

I found these snippets:

https://psalm.dev/r/7de1b5f18a

<?php

class MyReflectionProperty extends ReflectionProperty
{
    public function getValue(?object $object = null): mixed
    {
        return parent::getValue(...func_get_args());
    }

    public function setValue(mixed $objectOrValue, mixed $value = null): void
    {
        parent::setValue(...func_get_args());
    }
}

Psalm output (using commit 1a1b5a9):

ERROR: MethodSignatureMismatch - 5:38 - Argument 1 of MyReflectionProperty::getValue has wrong type 'null|object', expecting 'object' as defined by ReflectionProperty::getValue

INFO: MixedArgument - 7:36 - Argument 1 of ReflectionProperty::getValue cannot be mixed, expecting object

ERROR: MethodSignatureMismatch - 10:36 - Argument 1 of MyReflectionProperty::setValue has wrong type 'mixed', expecting 'null|object' as defined by ReflectionProperty::setValue

[orklah]

Yeah, that seem correct. Would you mind pushing a PR that changes the callmap on that regard?

Thanks

[derrabus]

I gave it a try: #7402

[weirdan]

The original snippet no longer results in MethodSignatureMismatch, so I think it's solved now.