Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix dir Callmap #7347

Merged
merged 1 commit into from Jan 8, 2022
Merged

Fix dir Callmap #7347

merged 1 commit into from Jan 8, 2022

Conversation

VincentLanglet
Copy link
Contributor

Closes #7345

If I understand correctly your message @weirdan

But since this was zpp-null, you need to drop null from all callmaps.

@VincentLanglet VincentLanglet mentioned this pull request Jan 8, 2022
Closed
@weirdan weirdan added the release:fix The PR will be included in 'Fixes' section of the release notes label Jan 8, 2022
@weirdan
Copy link
Collaborator

weirdan commented Jan 8, 2022

If I understand correctly your message

You absolutely did, thanks!

@weirdan weirdan merged commit f9e6ff3 into vimeo:4.x Jan 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weirdan weirdan weirdan approved these changes

Assignees
No one assigned
Labels
release:fix The PR will be included in 'Fixes' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

dir has wrong return type Directory|false|null instead of Directory|false
2 participants
@VincentLanglet @weirdan