dir has wrong return type Directory|false|null instead of Directory|false

[VincentLanglet]

Hi @orklah,

I run into the following issue

• Psalm consider dir to return Directory|false|null
• PHPStan consider dir to return Directory|false

The previous type was introduced by @voku in #1541

I did some research, and it seems that the php doc was updated recently from Directory|false|null to Directory|false.
php/doc-en#903

But I'm not sure which CallMap should be modified then...

[psalm-github-bot]

Hey @VincentLanglet, can you reproduce the issue on https://psalm.dev ?

[weirdan]

It's changed in PHP 7.2: php/php-src@b71b128#diff-a6738c9e7e606e49fc4e7225c281deca86191ada31a5dc077169418541541d1cL218

[weirdan]

Actually, in 8.0: https://3v4l.org/RfVEi, when ZPP started to throw. But since this was zpp-null, you need to drop null from all callmaps.

[VincentLanglet]

But since this was zpp-null, you need to drop null from all callmaps.

Did #7347 then