Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deprecate forbidEcho #6902

Merged
merged 1 commit into from Jan 14, 2022
Merged

deprecate forbidEcho #6902

merged 1 commit into from Jan 14, 2022

Conversation

orklah
Copy link
Collaborator

@orklah orklah commented Nov 12, 2021

This will fix #6892

@orklah orklah added the release:deprecation The PR will be included in 'Deprecated' section of the release notes label Nov 12, 2021
@orklah
Copy link
Collaborator Author

orklah commented Nov 13, 2021

This is failing on PSL 1.9 because they use this config.
PSL 2 stopped using it so it would require retrieving this branch from the main repo and switching the tests on it.

This is not urgent though, so it'll wait for now

@orklah orklah changed the base branch from master to 4.x January 14, 2022 18:30
@orklah orklah merged commit cdbaf0e into vimeo:4.x Jan 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weirdan weirdan weirdan approved these changes

Assignees
No one assigned
Labels
release:deprecation The PR will be included in 'Deprecated' section of the release notes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

deprecate forbid_echo
2 participants
@orklah @weirdan