deprecate forbidEcho

vimeo · Jan 14, 2022 · 8ee62cf · 8ee62cf
1 parent 3a09784
commit 8ee62cf
Show file tree

Hide file tree

Showing 3 changed files with 9 additions and 2 deletions.
diff --git a/config.xsd b/config.xsd
@@ -67,7 +67,13 @@
         <xs:attribute name="findUnusedCode" type="xs:boolean" default="false" />
         <xs:attribute name="findUnusedVariablesAndParams" type="xs:boolean" default="false" />
         <xs:attribute name="findUnusedPsalmSuppress" type="xs:boolean" default="false" />
-        <xs:attribute name="forbidEcho" type="xs:boolean" default="false" />
+        <xs:attribute name="forbidEcho" type="xs:boolean" default="false">
+            <xs:annotation>
+                <xs:documentation xml:lang="en">
+                    Deprecated. Will be replaced by adding echo to forbiddenFunctions in Psalm 5.
+                </xs:documentation>
+            </xs:annotation>
+        </xs:attribute>
         <xs:attribute name="hideExternalErrors" type="xs:boolean" default="false" />
         <xs:attribute name="hoistConstants" type="xs:boolean" default="false" />
         <xs:attribute name="ignoreInternalFunctionFalseReturn" type="xs:boolean" default="true" />

diff --git a/docs/running_psalm/issues/ForbiddenEcho.md b/docs/running_psalm/issues/ForbiddenEcho.md
@@ -1,7 +1,7 @@
 # ForbiddenEcho
 
 Emitted when Psalm encounters an echo statement and the `forbidEcho` flag in your config is set to `true`
-
+This issue is deprecated and will be removed in Psalm 5. Adding echo to forbiddenFunctions in config will result in ForbiddenCode issue instead
 ```php
 <?php
 

diff --git a/src/Psalm/Config.php b/src/Psalm/Config.php
@@ -792,6 +792,7 @@ private static function processConfigDeprecations(
         $deprecated_attributes = [
             'allowCoercionFromStringToClassConst',
             'allowPhpStormGenerics',
+            'forbidEcho'
         ];
 
         $deprecated_elements = [