PHAR: add config.xsd to generated PHAR package
#10955
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Maximilian Bösing <2189546+boesing@users.noreply.github.com>
boesing
force-pushed
the
feature/phar-with-config-xsd
branch
from
3b7632c
to
82db53f
Compare
This was referenced May 5, 2024
|
Duplicate of #10938 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In most projects I am working on, the
config.xsdis referenced from within the projectspsalm.xml(viaxsi:noNamespaceSchemaLocation).That provides decent auto-completion, etc. and thus is usually recommended to represent the latest configuration schema.
That was done by having
vendor/vimeo/psalm/config.xsdas that schema is located forvimeo/psalmusage.When using
psalm/phar, that does not work as the file is not part of the pacakge. This PR is changing that and will add theconfig.xsdwith whatever next version is generated after merging these changes.