Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Provide config.xsd for psalm/phar composer package #18

Open
boesing opened this issue May 5, 2024 · 2 comments
Open

Provide config.xsd for psalm/phar composer package #18

boesing opened this issue May 5, 2024 · 2 comments

Comments

@boesing
Copy link

boesing commented May 5, 2024

Hey there,
I wonder if it is possible to have the config.xsd file available from within this package?

I do maintain https://github.com/laminas/laminas-ci-matrix-action which does detect psalm.xml/psalm.xml.dist.
As of now, we assume that once that config file is available, vimeo/psalm will be installed afterwards. Though we register a CI job for static analysis via psalm which executes a previous check which verifies that the psalm.xml matches config.xsd requirements via xmllint --schema vendor/vimeo/psalm/config.xsd psalm.xml.

We do have a feature request to also support psalm/phar. I was thinking about a way how we could properly support that and came up with the fact that we should relocate the config.xsd in that case to vendor/psalm/phar/config.xsd instead but the file is not bundled during package generation.

Could some1 target me to the project/workflow which generates the PHAR so that I can provide a patch where the config.xsd is bundled in upcoming versions? I do not expect this to be handled for already released versions but I think it could provide some benefits for future usage of this package.

@zonuexe
Copy link

zonuexe commented May 5, 2024

Related PR: vimeo/psalm#10938

@boesing

This comment was marked as outdated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants