Fixes #7246, wrap getTypeContextAtPosition in try/catch #7247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
FYI: The Psalm error should be fixed but it's out of the scope of this PR because it was already broken before my code additions |
|
Yeah, it's a false positive, and a pretty convoluted one. You should be able to extract the conditional that checks both variable are not null from the try/catch and it should work fine. |
|
@orklah are you talking about this PR or the bugs outside the context of this PR (sorry just a little confused :-) ) |
|
Sorry, I was talking about that failure in CI: https://github.com/vimeo/psalm/runs/4669003160?check_suite_focus=true#step:4:30 |
orklah
added
the
release:fix
|
Thanks! |
This was referenced Jan 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #7246 and psalm/psalm-vscode-plugin#107
Specifically if something crashes deep in Psalm we should try to catch most of these crashes in the language server and continue (if possible). This is one such instance where continuing is fine as the error comes from the result of live typing so the code completion (that is erroring) is wrong as the time of typing the letters.
This is really hard to actually give a code reproduction because it relies on Psalm having a live cache and then that cache changing while live typing. You can see this in the reference issue against psalm-vscode-plugin